On Thu, 28 Jul 2016, Julien Grall wrote: > The level shift can be encoded with 32-bit. So it is not necessary to > use paddr_t (i.e 64-bit).
You might as well use 8 bit. > Signed-off-by: Julien Grall <julien.gr...@arm.com> > --- > xen/arch/arm/p2m.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c > index a6dce0c..798faa8 100644 > --- a/xen/arch/arm/p2m.c > +++ b/xen/arch/arm/p2m.c > @@ -675,7 +675,7 @@ static const paddr_t level_sizes[] = > { ZEROETH_SIZE, FIRST_SIZE, SECOND_SIZE, THIRD_SIZE }; > static const paddr_t level_masks[] = > { ZEROETH_MASK, FIRST_MASK, SECOND_MASK, THIRD_MASK }; > -static const paddr_t level_shifts[] = > +static const unsigned int level_shifts[] = > { ZEROETH_SHIFT, FIRST_SHIFT, SECOND_SHIFT, THIRD_SHIFT }; > > static int p2m_shatter_page(struct p2m_domain *p2m, > -- > 1.9.1 > _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel