On Fri, Aug 12, 2016 at 04:02:11PM +0200, Samuel Thibault wrote: > Wei Liu, on Fri 12 Aug 2016 15:01:07 +0100, wrote: > > BUILD_BUG_ON should not appear in a public-facing header, otherwise it > > risks clashing with macro with the same name in other code bases. I > > encountered such issue when trying to add BUILD_BUG_ON to a private > > header in Xen's gnttab library. > > > > Ideally BUILD_BUG_ON should be moved to a private header, but there is > > actually no user of it in mini-os tree, just remove it. > > > > Signed-off-by: Wei Liu <wei.l...@citrix.com> > > Acked-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> >
Actually some stuff in stubdom depends on mini-os leaking BUILD_BUG_ON, while some actively work around the leaking of some other macros. I will hold off putting in this patch for now. Wei. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
