On 08/03/2016 01:03 PM, David Vrabel wrote: > The standard return value for ioctl(2) where the cmd is not supported > is ENOTTY, not EINVAL. > > Signed-off-by: David Vrabel <david.vra...@citrix.com> > --- > drivers/xen/privcmd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/xen/privcmd.c b/drivers/xen/privcmd.c > index 702040f..ac76bc4 100644 > --- a/drivers/xen/privcmd.c > +++ b/drivers/xen/privcmd.c > @@ -572,7 +572,7 @@ static long privcmd_ioctl(struct file *file, > break; > > default: > - ret = -EINVAL; > + ret = -ENOTTY; > break; > } >
evtchn_ioctl() returns -ENOSYS so probably also should be fixed. In fact, ioctls in drivers/xen/ should be made consistent in what they do for unknown command. -boris _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
