On 01/08/16 11:29, Jan Beulich wrote: >>>> On 14.07.16 at 17:58, <andrew.coop...@citrix.com> wrote: >> --- a/xen/include/xen/types.h >> +++ b/xen/include/xen/types.h >> @@ -1,6 +1,8 @@ >> #ifndef __TYPES_H__ >> #define __TYPES_H__ >> >> +#include <xen/stdbool.h> >> + >> #include <asm/types.h> >> >> #define BITS_TO_LONGS(bits) \ >> @@ -59,4 +61,8 @@ typedef __u64 __be64; >> >> typedef unsigned long uintptr_t; >> >> +typedef _Bool bool_t; > I see this went in already, but I think it is slightly sub-optimal: Either > you use _Bool here and don't include xen/stdbool.h above, or you > instead use bool in this typedef.
We should include xen/stdbool.h to get true and false. Switching this to bool is easy enough. ~Andrew _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
