On Sun, Jul 10, 2016 at 02:47:32PM +0300, Emil Condrea wrote: > The purpose of the new file is to store generic functions shared by frontend > and backends such as xenstore operations, xendevs. > > Signed-off-by: Quan Xu <quan...@intel.com> > Signed-off-by: Emil Condrea <emilcond...@gmail.com> > --- > hw/xen/Makefile.objs | 2 +- > hw/xen/xen_backend.c | 125 +----------------------------------- > hw/xen/xen_pvdev.c | 149 > +++++++++++++++++++++++++++++++++++++++++++ > include/hw/xen/xen_backend.h | 63 +----------------- > include/hw/xen/xen_pvdev.h | 71 +++++++++++++++++++++ > 5 files changed, 223 insertions(+), 187 deletions(-) > create mode 100644 hw/xen/xen_pvdev.c > create mode 100644 include/hw/xen/xen_pvdev.h > > diff --git a/include/hw/xen/xen_pvdev.h b/include/hw/xen/xen_pvdev.h > new file mode 100644 > index 0000000..f60bfae > --- /dev/null > +++ b/include/hw/xen/xen_pvdev.h > @@ -0,0 +1,71 @@ > +#ifndef QEMU_HW_XEN_PVDEV_H > +#define QEMU_HW_XEN_PVDEV_H 1
No need for the 1. Just "#define X" is enough. > + > +#include "hw/xen/xen_common.h" > +#include <inttypes.h> I don't think this include is needed. -- Anthony PERARD _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
