On Mon, 2016-07-18 at 15:46 +0100, George Dunlap wrote: > On 15/07/16 15:49, Dario Faggioli wrote: > > > > This may look handy, but it introduced a (not especially well > > documented) dependency between the lenght of the window and > > the precision of the calculations, which really should be > > two independent things. Especially if treating them as such > > (like it is done in this patch) does not lead to more > > complex maths (same number of multiplications and shifts, and > > there is still room for some optimization). > > > > Therefore, in this patch, we: > > - split length of the window and precision (and, since there > > is already a command line parameter for length of window, > > introduce one for precision too), > > - align the math with one proper incarnation of exponential > > smoothing (at no added cost), > > - add comments, about the details of the algorithm and the > > math used. > > > > While there fix a couple of style issues as well (pointless > > initialization, long lines, comments). > > > > Signed-off-by: Dario Faggioli <dario.faggi...@citrix.com> > > --- > > Changes from v1: > > * reconciled comments and actual code about load_window_shift > > handling; > And this apparently means changing the code to match the comments > (not > the other way around), so that the actual load_window_shift default > is > now 30 (as the comments say) instead of 20 (as it was in the previous > patch). :-) > Indeed. I should have made it more clear that this is what's happening... Sorry! :-)
> Reviewed-by: George Dunlap <george.dun...@citrix.com> > Thanks, Dario -- <<This happens because I choose it to happen!>> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
signature.asc
Description: This is a digitally signed message part
_______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
