On 23/06/16 10:50, Jan Beulich wrote: >>>> On 23.06.16 at 11:44, <andrew.coop...@citrix.com> wrote: >> On 23/06/16 09:32, Jan Beulich wrote: >>> I wonder what good the duplication of the returned domain ID does: I'm >>> tempted to remove the one in the command-specific structure. Does >>> anyone have insight into why it was done that way? >> This hypercall, and its sibling XEN_SYSCTL_getdomaininfolist have crazy >> semantics, which go out of their way to make it easy to get wrong. >> >> It is important that you always check the returned domid, as it may not >> be the domain you asked for. In particular, if a domain you are looking >> after dies, the adjacent domain's information will be returnned. > Same question as to Marek: How is this related to my remark?
Oh right. I misread. Altering the domctl domid value is pointless, as libxc abstracts the call behind do_domctl() anyway. ~Andrew _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
