On 21/06/16 13:54, Oleksandr Tyshchenko wrote:
On Tue, Jun 21, 2016 at 3:15 PM, Julien Grall <julien.gr...@arm.com> wrote:
On Tue, Jun 21, 2016 at 12:15 PM, Dirk Behme <dirk.be...@de.bosch.com>
wrote:
I have some doubt that the current code is valid. The clock frequency is
hardcoded (see SCIF_CLK_FREQ), so are you saying that the frequency is
always the same across all the platforms?
No.
This driver has been initially written for Renesas Lager board based
on R-Car H2 SoC which
has SCIF compatible UART. And the current code is valid for it. I have
tested both auto and
variable (38400, 115200) baudrates.
But, I am afraid that current code won't be suitable for
all of the boards which have the same UART IP. It depends at least
from clock source
(external/internal) and clock frequency.
In this case, the code should either be fixed by reading the clock
frequency from the firmware tables or be dropped.
I would lean towards the later because the user cannot specify the baud
rate to Xen.
Regards,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
