>>> On 20.06.16 at 17:11, <dgde...@tycho.nsa.gov> wrote: > On 06/20/2016 10:46 AM, Doug Goldstein wrote: >> On 6/20/16 9:04 AM, Daniel De Graaf wrote: >>> Since enabling XSM is required to enable FLASK, place the option for >>> FLASK below the one for XSM. In addition, since it does not make sense >>> to enable XSM without any XSM providers, and FLASK is the only XSM >>> provider, hide the option to disable FLASK under EXPERT. >>> >>> Signed-off-by: Daniel De Graaf <dgde...@tycho.nsa.gov> >>> --- >> >>> @@ -137,6 +119,25 @@ config XSM >>> >>> If unsure, say N. >>> >>> +config FLASK >>> + def_bool y >>> + bool "FLux Advanced Security Kernel support" if EXPERT = "y" >> >> Ok. Here's the real review. I think you want the prompt to be optional >> if EXPERT is enabled then I think you need to use "prompt" instead of >> "bool". You've already got this set to a bool with the "def_bool" line. > > OK. This version also apparently works, since I tested it, but if > prompt is the preferred keyword I'll change it.
Yeah, the bool is redundant here. It should be either a def_bool/prompt pair, or a bool/default one. Personally I'd prefer the latter, but since Doug asked for the former that's fine too. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
