>>> On 16.06.16 at 13:04, <jgr...@suse.com> wrote: > On 16/06/16 12:54, Jan Beulich wrote: >>>>> On 16.06.16 at 12:02, <jgr...@suse.com> wrote: >>> In case the word size of the domU and qemu running the qdisk backend >>> differ BLKIF_OP_DISCARD will not work reliably, as the request >>> structure in the ring have different layouts for different word size. >>> >>> Correct this by copying the request structure in case of different >>> word size element by element in the BLKIF_OP_DISCARD case, too. >>> >>> Signed-off-by: Juergen Gross <jgr...@suse.com> >> >> With the indentation (tabs vs blanks) fixed > > Hmm, qemu coding style is to use blanks. I could: > a) leave the patch as is (changed lines indented with blanks) > b) use tabs to indent (style of the modified file up to now) > c) change the style of the file in this patch > d) change the style of the file in a separate patch > > Any preferences?
I'd say a) is not an option, but beyond that I think this needs to be answered by the qemu maintainers. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
