On 15/06/16 11:21, Jan Beulich wrote: >> I think you've tripped over "changing coding styles" in unfamiliar code >> before too, so you know how frustrating it is to try to follow the >> existing coding style only to be told that you did it wrong. :-) > > Agreed, you caught me on this one. Albeit with the slight > difference that in the public interface we can't as easily correct > old mistakes to aid people who simply clone surrounding code > when adding new bits (the possibility of adding #ifdef-ery doesn't > seem very attractive to me there, unless we got reports of actual > name space collisions).
Indeed; and just to be clear, I wasn't trying to criticize the deprecated coding style in the headers -- but given that there *is* deprecated coding style, it's worth a slight apology when asking people to use the new style instead of falling in line with what's already there. :-) -George _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
