On 09/06/16 16:26, Shanker Donthineni wrote:
diff --git a/xen/drivers/char/pl011.c b/xen/drivers/char/pl011.c
index a2f929b..d70ec99 100644
--- a/xen/drivers/char/pl011.c
+++ b/xen/drivers/char/pl011.c
@@ -41,6 +41,7 @@ static struct pl011 {
/* struct timer timer; */
/* unsigned int timeout_ms; */
/* bool_t probing, intr_works; */
+ bool sbsa; /* ARM SBSA generic interface */
} pl011_com = {0};
/* These parity settings can be ORed directly into the LCR. */
@@ -50,6 +51,7 @@ static struct pl011 {
#define PARITY_MARK (PEN|SPS)
#define PARITY_SPACE (PEN|EPS|SPS)
+/* To compatible with SBSA v2.x document, all accesses should be
32-bit */
The verb is missing. Also please add a full stop at the end of the
comment.
#define pl011_read(uart, off) readl((uart)->regs + (off))
#define pl011_write(uart, off,val) writel((val), (uart)->regs
+ (off))
[...]
Sorry, I didn't understand what is [...]?
It used to show that I dropped some part of your mail in my reply.
@@ -313,11 +323,15 @@ static int __init pl011_acpi_uart_init(const
void *data)
return -EINVAL;
}
+ if ( (spcr->interface_type == ACPI_DBG2_SBSA) ||
+ (spcr->interface_type == ACPI_DBG2_SBSA_32) )
+ sbsa = true;
I thought I already mentioned this on a previous version:
sbsa = (spcr->interface_type == ACPI_DBG2_SBSA || ...);
You want me change to
sbsa = (spcr->interface_type == ACPI_DBG2_SBSA || spcr->interface_type
== ACPI_DBG2_SBSA_32)
right?
Yes please.
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
