Hi Boris,
On 31/05/16 21:51, Boris Ostrovsky wrote:
On 05/31/2016 03:42 PM, Konrad Rzeszutek Wilk wrote:
On Tue, May 31, 2016 at 12:43:22PM +0800, Shannon Zhao wrote:
From: Shannon Zhao <shannon.z...@linaro.org>
The design of this feature is described as below.
Firstly, the toolstack (libxl) generates the ACPI tables according the
number of vcpus and gic controller.
CC-ing Boris - who has been working on exposing ACPI tables
for PVH guests.
Is there some way of re-using some of the code?
Indeed it would be good to keep all ACPI code in single place.
I sent a patch series a while ago
(http://lists.xenproject.org/archives/html/xen-devel/2016-04/msg00625.html)
but because of release work it hasn't been reviewed yet. Shannon, can
you take a look at it and see whether you code can make use of what is
proposed there? It builds all the tables that you are building here
except for GTDT and provides libxc interface.
AFAICT, your library is creating ACPI 1.0/2.0 tables. However the
support for ARM has been added in ACPI 5.1.
Looking at the list of tables built by the library, we might be able to
re-use the code for SRAT, SLIT, FADT, RSDP. The rest is x86 specific
(WAET, MADT, HPET, SSDT_{PM,S3,S4}, TCPA (?)).
In the current state, I think the benefits for ARM is very limited. I
agree that having a common library to manipulate ACPI would be nice,
however, this would need a better abstraction to support different
version and avoid to build unnecessary code.
Regards,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel