>>> On 31.05.16 at 12:22, <feng...@intel.com> wrote: > >> -----Original Message----- >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: Friday, May 27, 2016 9:49 PM >> To: Wu, Feng <feng...@intel.com> >> Cc: andrew.coop...@citrix.com; dario.faggi...@citrix.com; >> george.dun...@eu.citrix.com; Tian, Kevin <kevin.t...@intel.com>; xen- >> de...@lists.xen.org; konrad.w...@oracle.com; k...@xen.org >> Subject: Re: [PATCH v2 2/4] VMX: Cleanup PI per-cpu blocking list when vcpu > is >> destroyed >> >> >>> On 26.05.16 at 15:39, <feng...@intel.com> wrote: >> > --- a/xen/arch/x86/hvm/vmx/vmx.c >> > +++ b/xen/arch/x86/hvm/vmx/vmx.c >> > @@ -366,6 +366,7 @@ static void vmx_vcpu_destroy(struct vcpu *v) >> > vmx_destroy_vmcs(v); >> > vpmu_destroy(v); >> > passive_domain_destroy(v); >> > + vmx_pi_blocking_cleanup(v); >> > } >> >> Isn't this redundant with the cleanup done when the last device >> gets removed (via pci_release_devices()) during domain cleanup? > > We need to handle the following two cases: > - the last device gets removed (via 'xl pci-detach ...'), and the guest > is running after that. The logical in vmx_pi_hooks_deassign() cover > this case. > - the guest is shutting down. It is covered here.
Exactly. Yet that latter case is already being taken care of by the former: When the guest is shutting down, its last device will get removed anyway. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
