>>> On 25.05.16 at 17:56, <julien.gr...@arm.com> wrote:
> --- a/xen/common/compat/memory.c
> +++ b/xen/common/compat/memory.c
> @@ -253,6 +253,8 @@ int compat_memory_op(unsigned int cmd,
> XEN_GUEST_HANDLE_PARAM(void) compat)
> unsigned int size = cmp.atpb.size;
> xen_ulong_t *idxs = (void *)(nat.atpb + 1);
> xen_pfn_t *gpfns = (void *)(idxs + limit);
> + enum XLAT_add_to_physmap_batch_u u =
> + XLAT_add_to_physmap_batch_u_res0;
Here you're cheating, and to help future readers understand you are
you should say why this is okay in a comment. Or alternatively handle
things properly.
> --- a/xen/include/public/memory.h
> +++ b/xen/include/public/memory.h
> @@ -259,7 +259,15 @@ struct xen_add_to_physmap_batch {
>
> /* Number of pages to go through */
> uint16_t size;
> - domid_t foreign_domid; /* IFF gmfn_foreign */
> +
> +#if __XEN_INTERFACE_VERSION__ < 0x00040700
> + domid_t foreign_domid; /* IFF gmfn_foreign. Should be 0 for other
> spaces. */
> +#else
> + union add_to_physmap_batch_extra {
This lacks a xen_ prefix.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
