>>> On 24.05.16 at 10:11, <quan...@intel.com> wrote: > I thought the IOMMU / MM boundary is the MM functions (high level callers) > which call iommu_* interfaces (such as, iommu_map_page / iommu_unmap_page / > iommu_iotlb_flush ...).
Exactly - the boundary is _in_ those MM functions, at the points where they call IOMMU ones. > For this case, the xenmem_add_to_physmap() indeed calls iommu_iotlb_flush(), > but xenmem_add_to_physmap() may be hypervisor interface, instead of MM > interface. > > If I drop this __must_check and fix patch 3 / patch 5, then I think > __must_check would not be a block issue. Not sure what "a block issue" is supposed to mean here, but indeed if you drop the annotations from non-IOMMU functions (unless, as said, you mean to also add them further up the call trees), then I think things should be coming close. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
