On Wed, May 11, 2016 at 10:36:28AM +0200, Juergen Gross wrote:
> On 10/05/16 18:21, Anthony PERARD wrote:
> > On Fri, May 06, 2016 at 11:42:45AM +0200, Juergen Gross wrote:
> >> -static int xen_config_dev_mkdir(char *dev, int p)
> >> -{
> >> - struct xs_permissions perms[2] = {{
> >> - .id = 0, /* set owner: dom0 */
> >> - },{
> >> - .id = xen_domid,
> >> - .perms = p,
> >> - }};
> >> -
> >
> > The function looks like it as been tailored to mkdir for config of
> > backends. So it does not seems out of place.
>
> It has been tailored for config of _devices_ by the backend.
>
> I still think it would fit better now into xen_backend.c, OTOH in case
> you like it better in xen_devconfig.c I won't argue against it.
I guess the function looks generic enough. So I'm now fine with moving it
to xen_backend.c.
--
Anthony PERARD
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
