On May 10, 2016 4:51 PM, Jan Beulich <jbeul...@suse.com> wrote: > >>> On 06.05.16 at 10:54, <quan...@intel.com> wrote: > > Propagate the IOMMU Device-TLB flush error up to IOMMU unmapping. > > > > Signed-off-by: Quan Xu <quan...@intel.com> > > Acked-by: Kevin Tian <kevin.t...@intel.com> > > Reviewed-by: Jan Beulich <jbeul...@suse.com> > > but note ... > > > @@ -1766,9 +1769,7 @@ static int intel_iommu_unmap_page(struct > domain *d, unsigned long gfn) > > if ( iommu_passthrough && is_hardware_domain(d) ) > > return 0; > > > > - dma_pte_clear_one(d, (paddr_t)gfn << PAGE_SHIFT_4K); > > - > > - return 0; > > + return dma_pte_clear_one(d, (paddr_t)gfn << PAGE_SHIFT_4K); > > } > > ... how you lose the __must_check here, since > intel_iommu_unmap_page() isn't __must_check (which we said you may skip > as long as the common code wrapper has it, but in the context here I'm no > longer convinced skipping this at any layer is a good idea, as that makes > validation of the call trees more difficult). > (This is just a remark regarding the comment on the earlier patch, i.e. not > something needing any further change here.) >
I'll be bold to add __must_check.. Quan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
