>>> On 03.05.16 at 16:29, <car...@cardoe.com> wrote: > Convert the crash_debug option to Kconfig as CONFIG_CRASH_DEBUG. This > was previously togglable on the command line so this adds a message for > users enabling it from the command line to tell them to enable it from > make menuconfig. > > Signed-off-by: Doug Goldstein <car...@cardoe.com> > --- > CC: Jan Beulich <jbeul...@suse.com> > CC: Andrew Cooper <andrew.coop...@citrix.com>
I think the Cc list should be quite a bit wider here. > --- a/xen/Kconfig.debug > +++ b/xen/Kconfig.debug > @@ -5,3 +5,14 @@ menuconfig DEBUG > If you want to debug Xen say Y and select any additional debugging > support options. Enabling this option is intended for development > purposes only, and not for production use. > + > +if DEBUG Didn't we agree on "DEBUG || EXPERT" at the hackathon? With tha Reviewed-by: Jan Beulich <jbeul...@suse.com> But one more suggestion: > --- a/xen/include/asm-x86/debugger.h > +++ b/xen/include/asm-x86/debugger.h > @@ -39,7 +39,7 @@ > #define DEBUGGER_trap_fatal(_v, _r) \ > if ( debugger_trap_fatal(_v, _r) ) return; > > -#if defined(CRASH_DEBUG) > +#if defined(CONFIG_CRASH_DEBUG) #ifdef Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
