On Fri, Apr 29, 2016 at 03:57:23PM +0100, Wei Liu wrote: > On Fri, Apr 29, 2016 at 04:21:18PM +0200, Roger Pau Monne wrote: > > Some error paths incorrectly used rc instead of errno. > > > > Signed-off-by: Roger Pau Monné <roger....@citrix.com> > > --- > > Cc: Konrad Rzeszutek Wilk <konrad.w...@oracle.com> > > Cc: Ross Lagerwall <ross.lagerw...@citrix.com> > > Cc: Ian Jackson <ian.jack...@eu.citrix.com> > > Cc: Wei Liu <wei.l...@citrix.com> > > --- > > tools/misc/xen-xsplice.c | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/tools/misc/xen-xsplice.c b/tools/misc/xen-xsplice.c > > index 0f1ab5a..695be7f 100644 > > --- a/tools/misc/xen-xsplice.c > > +++ b/tools/misc/xen-xsplice.c > > @@ -273,7 +273,7 @@ int action_func(int argc, char *argv[], unsigned int > > idx) > > if ( rc ) > > { > > fprintf(stderr, "%s failed to get status (rc=%d, %s)!\n", > > I think it is better to also change rc= to errno= here.
Thanks. Yes, in fact I think I prefer the format used elsewhere in this file, which is: %d(%s) Roger. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel