>>> On 29.04.16 at 04:41, <quan...@intel.com> wrote:
> Now I check the status in caller to make the print include caller which is
> failed, instead print in iommu_flush_all().
> i.e.,
> vtd_crash_shutdown()
> {
> ..
> if ( iommu_flush_all() )
> printk(XENLOG_WARNING VTDPREFIX
> " vtd_crash_shutdown: IOMMU flush all failed.\n");
> ..
> }
>
> I am afraid I still don't get the point. To be honest, in such a fix,
> The print is not so useful to me ( Correct me, I will continue to enhance
> it).
So do you think it would be more useful to leave the admin with no
clue why a system misbehaves, instead of providing clear indication?
IOW - what usefulness concerns do you have?
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
