Hi Stefano,
On 22/04/16 10:42, Stefano Stabellini wrote:
On Tue, 12 Apr 2016, Julien Grall wrote:
The ARM implementation of share_xen_page_with_guest is nearly the same as the
x86 one. However, the type is never used so far for the P2M code.
So far, all ARM domains have been auto-translated. DOMID_XEN is the first non
auto-translated domain.
We could make DOMID_XEN an auto-translated domain by introducing page table
for dummy domain. This would make the code cleaner but use more memory
(allocation of 3 level of page tables).
Stefano, do you have any opinions on this?
If it is just one "if" or two the issue, I would keep DOMID_XEN as it is
now and deal with it as a special case. If we expect that we are going
to grow more "if domain_id == DOMID_XEN" all around the code base, then
I would follow your suggestion and make DOMID_XEN auto-translated. But
we don't need to decide now, we could go with the special if for the
moment and keep this in mind.
The plan sounds good to me. I cannot think of other place at the moment.
Regards,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
