>>> On 21.04.16 at 10:36, <andrew.coop...@citrix.com> wrote: > On 11/03/16 16:01, Jan Beulich wrote: >> In that case (with the new value being held in, or now in one case cast >> to, a 32-bit variable) there's no need to go through the long mode part >> of the checks. >> >> Primarily this was meant to hopefully address Coverity ID 1355278, but >> since the change produces smaller code as well I think we should use it >> even if it doesn't help that (benign) warning. >> >> Also it's more in line with jmp_rel() for commit_far_branch() to do the >> _regs.eip update, so adjust that at once. >> >> Signed-off-by: Jan Beulich <jbeul...@suse.com> > > Reviewed-by: Andrew Cooper <andrew.coop...@citrix.com>
Wei, considering that this at least attempts to address a Coverity issue, I'd like to ask for this to be considered to be allowed in despite being past code freeze. Thanks, Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
