On Tue, 12 Apr 2016, Wei Liu wrote:
> In commit ac0487e1 ("xenfb.c: avoid expensive loops when prod <=
> out_cons"), ">=" was used. In fact, a full ring is a legit state.
> Correct the test to use ">".
>
> Reported-by: "Hao, Xudong" <xudong....@intel.com>
> Signed-off-by: Wei Liu <wei.l...@citrix.com>
> Tested-by: "Hao, Xudong" <xudong....@intel.com>
> Acked-by: Anthony Perard <anthony.per...@citrix.com>
Acked-by: Stefano Stabellini <stefano.stabell...@eu.citrix.com>
I'll add it to my queue
> Cc: Stefano Stabellini <sstabell...@kernel.org>
> Cc: Anthony Perard <anthony.per...@citrix.com>
>
> Backport candidate to our own tree.
> ---
> hw/display/xenfb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/display/xenfb.c b/hw/display/xenfb.c
> index 40b096a..9866dfd 100644
> --- a/hw/display/xenfb.c
> +++ b/hw/display/xenfb.c
> @@ -775,7 +775,7 @@ static void xenfb_handle_events(struct XenFB *xenfb)
>
> prod = page->out_prod;
> out_cons = page->out_cons;
> - if (prod - out_cons >= XENFB_OUT_RING_LEN) {
> + if (prod - out_cons > XENFB_OUT_RING_LEN) {
> return;
> }
> xen_rmb(); /* ensure we see ring contents up to prod */
> --
> 2.1.4
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
