On Tue, Apr 12, 2016 at 01:56:50AM +0000, Hao, Xudong wrote: > > -----Original Message----- > > From: Wei Liu [mailto:wei.l...@citrix.com] > > Sent: Monday, April 11, 2016 6:54 PM > > To: Samuel Thibault <samuel.thiba...@ens-lyon.org>; Wei Liu > > <wei.l...@citrix.com>; Hao, Xudong <xudong....@intel.com>; Konrad > > Rzeszutek Wilk <konrad.w...@oracle.com>; xen-devel@lists.xen.org; > > stefano.stabell...@eu.citrix.com; Anthony PERARD <anthony.per...@citrix.com> > > Subject: Re: [Xen-devel] pv-grub guest booting fail with recent qemu-xen > > > > On Sun, Apr 10, 2016 at 10:14:46PM +0200, Samuel Thibault wrote: > > > Hello, > > > > > > > > > > + if (prod - out_cons >= XENFB_OUT_RING_LEN) { > > > > > > > + return; > > > > > > > + } > > > > > > This test seems overzealous to me: AIUI, the producer can produce > > > XENFB_OUT_RING_LEN events, and thus prod - out_cons is exactly > > > XENFB_OUT_RING_LEN, i.e. there is no room left at all. > > > > > > The frontend part is: > > > > > > while (page->out_prod - page->out_cons == XENFB_OUT_RING_LEN) > > > schedule(); > > > > > > I.e. it waits while the buffer is exactly full. > > > > > > So it seems to me the bug is at the backend side. > > > > > > > OK, thanks for checking! > > > > Hudong, can you try the following diff? > > Yes, This patch works with testing. >
Thanks for testing! I will submit this patch properly. Wei. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
