> -----Original Message----- > From: Xen-devel [mailto:xen-devel-boun...@lists.xen.org] On Behalf Of > Paul Durrant > Sent: 29 March 2016 10:58 > To: Jan Beulich > Cc: xen-de...@lists.xenproject.org > Subject: Re: [Xen-devel] [PATCH v2] x86/hvm/viridian: save APIC assist > vector > > > -----Original Message----- > > From: Jan Beulich [mailto:jbeul...@suse.com] > > Sent: 29 March 2016 10:53 > > To: Paul Durrant > > Cc: xen-de...@lists.xenproject.org > > Subject: Re: [PATCH v2] x86/hvm/viridian: save APIC assist vector > > > > >>> On 29.03.16 at 11:30, <paul.durr...@citrix.com> wrote: > > > If any vcpu has a pending APIC assist when the domain is suspended > > > then the vector needs to be saved. If this is not done then it's > > > possible for the vector to remain pending in the vlapic ISR > > > indefinitely after resume. > > > > > > This patch adds code to save the APIC assist vector value in the > > > viridian vcpu save record. This means that the record is now zero- > > > extended on load and, because this implies a loaded value of > > > zero means nothing is pending (for backwards compatibility with > > > hosts not implementing APIC assist), the rest of the viridian APIC > > > assist code is adjusted to treat a zero value in this way. A > > > check has therefore been added to viridian_start_apic_assist() to > > > prevent the enlightenment being used for vectors < 0x10 (which > > > are illegal for an APIC). > > > > > > Signed-off-by: Paul Durrant <paul.durr...@citrix.com> > > > > Reviewed-by: Jan Beulich <jbeul...@suse.com> > > > > Are you then also looking into the domain page leaks which seem > > likely to stem from the earlier APIC assist change? > > > > Yes, I'm going to look at them. Not sure why the vcpu shutdown code is not > releasing things. >
Ah. It appears to doesn't get called when the domain is shut down, that's why. I guess the viridian_vcpu_deinit() call needs relocating then. Paul > Paul > > > Jan > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
