>>> On 24.03.16 at 21:00, <konrad.w...@oracle.com> wrote:
> +struct xen_sysctl_xsplice_list {
> + uint32_t version; /* OUT: Hypervisor stamps value.
> + If varies between calls, we
> are
> + getting stale data. */
> + uint32_t idx; /* IN: Index into hypervisor
> array.
> + Should be between [0, nr). */
This is now actively wrong, when comparing with the implementation
in the next patch, namely
if ( list->idx > i++ )
continue;
E.g. on some subsequent invocation you might have idx=55 and
nr=32, making you populate array slots [0,31] with data for payloads
[55,86]. Why don't you just say "Index into hypervisor list"?
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
