> From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: Friday, March 18, 2016 4:06 PM > > >>> On 18.03.16 at 03:30, <quan...@intel.com> wrote: > > Any good idea? To be honest, I am very tired to at splitting things like > > this :). > > I understand that this is a tedious task; the code should have been > propagating errors from the beginning. > > The most natural way of splitting things would be to go function by > function, top level ones first, and leaf ones last, one function per > patch (maybe pairs of functions, as in the map/unmap case). Such > model would be problematic (almost) only when there's recursion at > some point, which I don't think would be the case anywhere here. > As mentioned before, the __must_check annotation is a great help > to not miss any callers - both to you as you put things together and > to the reviewers to be ascertained that nothing was missed. >
Agree with this suggestion. It also allows different maintainers to focus on changes they really need to care about. Thanks Kevin _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
