>>> On 16.03.16 at 13:54, <car...@cardoe.com> wrote: > On 3/16/16 3:47 AM, Jan Beulich wrote: >>>>> On 15.03.16 at 21:18, <car...@cardoe.com> wrote: >>> Wrap the various tmem functions with the Kconfig generated CONFIG_TMEM >>> option allowing users to build Xen without tmem support. >>> >>> Signed-off-by: Doug Goldstein <car...@cardoe.com> >>> --- >>> CC: Keir Fraser <k...@xen.org> >>> CC: Jan Beulich <jbeul...@suse.com> >>> CC: Andrew Cooper <andrew.coop...@citrix.com> >>> CC: Konrad Rzeszutek Wilk <konrad.w...@oracle.com> >>> >>> changes from v1: >>> - add description provided by Konrad (thanks!) >>> - tweaks to Makefile suggested by Jan >> >> Only kind of: >> >>> @@ -65,7 +63,12 @@ obj-bin-$(CONFIG_X86) += $(foreach n,decompress bunzip2 >>> unxz > unlzma unlzo unlz4 >>> obj-$(perfc) += perfc.o >>> obj-$(crash_debug) += gdbstub.o >>> >>> -obj-$(CONFIG_COMPAT) += $(addprefix compat/,domain.o kernel.o memory.o > multicall.o tmem_xen.o xlat.o) >>> +obj-$(CONFIG_COMPAT) += $(addprefix compat/,domain.o kernel.o memory.o > multicall.o xlat.o) >>> + >>> +tmem-y += tmem.o >>> +tmem-y += tmem_xen.o >> >> I had intentionally suggested >> >> tmem-y := tmem.o tmem_xen.o >> >> Splitting this up into two lines is a matter of taste, but not using := is >> inefficient, as it requires make to possibly expand the variable many >> times instead of just once. >> >> But anyway - since functionality wise this is fine, with or without that >> further adjustment >> Acked-by: Jan Beulich <jbeul...@suse.com> >> >> Jan >> > > You're right. Its worth correcting. I'll post a v3. Can I retain your > Acked-by?
Sure - I had said so already (see above). Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
