Changlong Xie writes ("[PATCH v11 01/27] tools/libxl: introduction of libxl__qmp_restore to load qemu state"): > From: Wen Congyang <we...@cn.fujitsu.com> > > In normal migration, the qemu state is passed to qemu as a parameter. > With COLO, secondary vm is running. So we will do the following steps > at every checkpoint: > 1. suspend both primary vm and secondary vm > 2. sync the state > 3. resume both primary vm and secondary vm > Primary will send qemu's state in step2, and secondary's qemu should > read it and restore the state before it is resumed. We can not pass the > state to qemu as a parameter because secondary QEMU is already started > at this point, so we introduce libxl__qmp_restore() to do it.
We should accept both the Xen part and the Qemu part, or neither. So I think this proposal needs (in the Xen commit message) a reference to the Qemu upstream commit, or Qemu upstream patches, so that we can see that they've got the appropriate Qemu upstream acks. But, subject to that, from a Xen point of view this approach looks good to me. Acked-by: Ian Jackson <ian.jack...@eu.citrix.com> Ian. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel