>>> On 25.02.16 at 15:56, <anthony.per...@citrix.com> wrote:
> --- a/tools/firmware/hvmloader/hvmloader.c
> +++ b/tools/firmware/hvmloader/hvmloader.c
> @@ -303,6 +303,15 @@ int main(void)
>
> smp_initialise();
>
> + /* Check that tests does not use memory where modules are stored */
> + BUG_ON( ((uint32_t)hvm_start_info + sizeof(struct hvm_start_info)) >= 4
> << 20 );
> + for ( unsigned i = 0; i < hvm_start_info->nr_modules; i++ )
> + {
> + const struct hvm_modlist_entry *modlist =
> + (struct hvm_modlist_entry *)hvm_start_info->modlist_paddr;
> + if ( modlist[i].size )
> + BUG_ON( modlist[i].paddr + modlist[i].size >= 4ul << 20 );
> + }
First of all both checks should use > instead of >=. And then
expecting all modules to live below 4Mb doesn't seem very
reasonable.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
