> Quoting you patch (v12, because it looks slightly better, but
> the difference doesn't matter for this discussion):
>
> #define arch_vcpu_block(v) ({ \
> if ( (v)->domain->arch.hvm_domain.vmx.vcpu_block ) \
> (v)->domain->arch.hvm_domain.vmx.vcpu_block((v)); \
> })
>
> and quoting asm-x86/domain.h:
>
> struct arch_domain
> {
> ...
> union {
> struct pv_domain pv_domain;
> struct hvm_domain hvm_domain;
> };
> ...
> };
>
> Hence accessing the field for PV domains is invalid.
Oh, that is right! Accessing 'hvm_domain' itself needs to be gated by
has_hvm_container_vcpu(), Thanks for pointing this out!
Thanks,
Feng
>
> Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
