fdopen returns NULL on failure, not a negative integer.
CID 1306863
CID 1306858
Signed-off-by: George Dunlap <george.dun...@citrix.com>
---
Strangely, coverity counted this as two bugs: one for comparing a
pointer with a negative integer, one for the comparison never possibly
being true (thus making the if condition dead code).
CC: Ian Jackson <ian.jack...@citrix.com>
CC: Wei Liu <wei.l...@citrix.com>
---
tools/xentrace/xenalyze.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/xentrace/xenalyze.c b/tools/xentrace/xenalyze.c
index 123030a..249bebd 100644
--- a/tools/xentrace/xenalyze.c
+++ b/tools/xentrace/xenalyze.c
@@ -9029,7 +9029,7 @@ void progress_init(void) {
opt.progress = 0;
}
- if( (G.progress.out = fdopen(G.progress.pipe[1], "w")) < 0 ) {
+ if( (G.progress.out = fdopen(G.progress.pipe[1], "w")) == NULL ) {
fprintf(stderr, "%s: could not fdopen pipe: %s, disabling progress
bar\n",
__func__, strerror(errno));
opt.progress = 0;
--
2.1.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
