>>> On 23.02.16 at 17:31, <andrew.coop...@citrix.com> wrote:
> In preparation for using superpage mappings, .data and .bss will both want to
> be mapped as read-write. By making them adjacent, they can share the same
> superpage and will not require superpage alignment between themselves.
>
> While making this change, fix an exposed alignment bug. __init_end only needs
> page alignment, while .bss.stack_aligned needs STACK_SIZE alignment.
Well, this has become a bug only with your changes (perhaps
that what you mean with "fix an exposed alignment bug", but
it reads as if there was a latent one, which isn't the case afaict).
> .bss : { /* BSS */
> __bss_start = .;
> + . = ALIGN(STACK_SIZE);
These two lines should be swapped - there's no point in starting
the BSS ahead of the alignment, causing us to needlessly zero
a few more pages during boot.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
