On Thu, Feb 18, 2016 at 06:19:07PM +0100, Olaf Hering wrote: > On Thu, Feb 18, Wei Liu wrote: > > > Sorry I don't follow. What do you mean by 1:1 copy? Why does it make the > > update unnecessary? > > The current code does: > > libxl_device_nic_init(&nic_saved); > libxl_device_nic_copy(CTX, &nic_saved, nic); > nic->devid = libxl__device_nextid(gc, domid, "vif"); > libxl__update_config_nic(gc, &nic_saved, nic); > > Which is equivalent to the more obvious version: > > libxl_device_nic_init(&nic_saved); > nic->devid = libxl__device_nextid(gc, domid, "vif"); > libxl_device_nic_copy(CTX, &nic_saved, nic); > > The input gets modified either way. Is it expected that future versions > of libxl_device_nic/vtmp_copy will not duplicate the mac/uuid parts? >
You missed libxl__device_nic_setdefault -- it changes fields in the structure. Wei. > > Olaf _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
