>>> On 18.02.16 at 17:39, <ian.jack...@eu.citrix.com> wrote:
> Jan Beulich writes ("Re: [PATCH v3 5/5] mkelf32: Close those file descriptors
> in the error paths."):
>> On 12.02.16 at 04:08, <konrad.w...@oracle.com> wrote:
>> > While we are operating here we may as well fix some of the
>> > file descriptor leaks.
>>
>> I'm not convinced. The added goto-s make the code uglier to read,
>> and this being a standalone utility there's not really any leak here.
>
> I don't buy this `uglier to read'. What `return 1' does is make me
> think `is some resource being leaked' and `do I need to audit this
> thing'.
Certainly a matter of taste to some degree - goto-s are always
ugly to read to my eyes. Irrespective of this I don't buy the leak
aspect for a non-library like, short running build utility. The close()
calls are just more code, with absolutely no added benefit to the
system the code runs on.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
