>>> On 16.02.16 at 21:20, <andrew.coop...@citrix.com> wrote:
> On 12/02/16 18:05, Konrad Rzeszutek Wilk wrote:
>> +static void xsplice_print_build_id(char *id, unsigned int len)
>> +{
>> + unsigned int i;
>> +
>> + if ( !len )
>> + return;
>> +
>> + for ( i = 0; i < len; i++ )
>> + {
>> + uint8_t c = id[i];
>> + printk("%02x", c);
>
> What about the already existing %*ph custom format? If the spaces are a
> problem we could introduce %*phN from Linux which has no spaces.
>
> The advantage of this is that it is a single call to printk, rather than
> many, and avoids the ability for a different cpu to interleave in the
> middle of a line.
I don't think this ability exists anymore after we've switched to
per-CPU there. Which isn't to say, though, that I wouldn't also
like to see this be just a single printk().
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
