>>> On 05.02.16 at 14:42, <andrew.coop...@citrix.com> wrote: > @@ -87,6 +88,93 @@ static void update_domain_cpuid_info(struct domain *d, > d->arch.x86_model = (ctl->eax >> 4) & 0xf; > if ( d->arch.x86 >= 0x6 ) > d->arch.x86_model |= (ctl->eax >> 12) & 0xf0; > + > + if ( is_pv_domain(d) )
For clarity, wouldn't it be reasonable to check the respective capability flag in all of these conditionals, even if without such checks what gets set below simply won't ever get used? Even more, the earlier patch allocating d->arch.pv_domain.cpuidmasks could skip this allocation if none of the masking capability bits are set (in which case checking the pointer to be non-NULL would seem to be the right check here then). Either way, Reviewed-by: Jan Beulich <jbeul...@suse.com> Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
