>>> On 05.02.16 at 14:42, <andrew.coop...@citrix.com> wrote: > --- /dev/null > +++ b/xen/arch/x86/cpuid.c > @@ -0,0 +1,19 @@ > +#include <xen/lib.h> > +#include <asm/cpuid.h> > + > +const uint32_t known_features[] = INIT_KNOWN_FEATURES; > + > +static void __maybe_unused build_assertions(void) > +{ > + BUILD_BUG_ON(ARRAY_SIZE(known_features) != FSCAPINTS);
This is sort of redundant with ... > --- /dev/null > +++ b/xen/include/asm-x86/cpuid.h > @@ -0,0 +1,24 @@ > +#ifndef __X86_CPUID_H__ > +#define __X86_CPUID_H__ > + > +#include <asm/cpuid-autogen.h> > + > +#define FSCAPINTS FEATURESET_NR_ENTRIES > + > +#ifndef __ASSEMBLY__ > +#include <xen/types.h> > + > +extern const uint32_t known_features[FSCAPINTS]; ... the use of FSCAPINTS here. You'd catch more mistakes if you just used [] here. But either way Acked-by: Jan Beulich <jbeul...@suse.com> Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel