On 02/11/2016 09:55 PM, Andrew Cooper wrote: > On 11/02/16 19:54, Razvan Cojocaru wrote: >> On 02/11/2016 09:51 PM, Tamas K Lengyel wrote: >>> While the public vm_event header specifies fs_base/gs_base as registers that >>> should be recorded for each event, that hasn't actually been the case. In >>> this patch we remedy the issue. >>> >>> Signed-off-by: Tamas K Lengyel <tleng...@novetta.com> >>> Cc: Razvan Cojocaru <rcojoc...@bitdefender.com> >>> Cc: Keir Fraser <k...@xen.org> >>> Cc: Jan Beulich <jbeul...@suse.com> >>> Cc: Andrew Cooper <andrew.coop...@citrix.com> >>> --- >>> xen/arch/x86/hvm/event.c | 9 ++++++++- >>> 1 file changed, 8 insertions(+), 1 deletion(-) >> Fair enough. >> >> Acked-by: Razvan Cojocaru <rcojoc...@bitdefender.com> > > Oops. > > Reviewed-by: Andrew Cooper <andrew.coop...@citrix.com>
This has actually been intentional, in that we've only needed those fields for EPT events, and thought that not filling what's not needed until it's needed would save a tiny bit of hypervisor processing time. They are being filled in only for page fault events at the moment. I believe it's been discussed at the time. We still don't need those coming with the events that use hvm_event_fill_regs(), but if Tamas needs them then by all means. Thanks, Razvan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
