On Fri, Feb 05, Olaf Hering wrote:
> +int xlu_vscsi_detach(XLU_Config *cfg, libxl_ctx *ctx, uint32_t domid, char
> *str)
> +{
> + if (vc->num_vscsidevs > 1) {
> + /* Remove single vscsidev connected to this vscsictrl */;
> + ctrl.devid = vc->devid;
> + ctrl.vscsidevs[0].vscsidev_id = vd->vscsidev_id;
> + libxl_device_vscsidev_remove(ctx, domid, &ctrl, NULL);
> + } else {
> + /* Wipe entire vscsictrl */;
> + libxl_device_vscsictrl_remove(ctx, domid, vc, NULL);
In this version I have moved the decision to remove vscsictrl into
libxlu. I wonder if thats a valid approach. Should there be a
libxl_device_vscsidev_remove which takes a *vscsidev, walks the list of
vscsictrls in xenstore and then calls either a variant of
libxl_device_vscsictrl_remove or libxl__device_vscsidev_rm?
Please advice.
Olaf
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
