>>> On 05.02.16 at 15:41, <andrew.coop...@citrix.com> wrote:
> On 05/02/16 08:01, Jan Beulich wrote:
>> --- a/xen/arch/x86/mm/paging.c
>> +++ b/xen/arch/x86/mm/paging.c
>> @@ -844,6 +844,15 @@ void paging_final_teardown(struct domain
>> * creation. */
>> int paging_enable(struct domain *d, u32 mode)
>> {
>> + switch ( mode & (PG_external | PG_translate) )
>> + {
>> + case 0:
>> + case PG_external | PG_translate:
>> + break;
>> + default:
>> + return -EINVAL;
>> + }
>
> if ( (mode & PG_external) != (mode & PG_translate) )
> return -EINVAL;
>
> seems rather more concise.
But wrong. Would need !() on each side at least.
> Otherwise, Reviewed-by: Andrew Cooper <andrew.coop...@citrix.com>
>
> Definitely a good improvement.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
