>>> On 29.01.16 at 17:32, <tleng...@novetta.com> wrote:
> On Fri, Jan 29, 2016 at 9:19 AM, Jan Beulich <jbeul...@suse.com> wrote:
>> >>> On 29.01.16 at 17:12, <tleng...@novetta.com> wrote:
>> > On Fri, Jan 29, 2016 at 4:03 AM, Jan Beulich <jbeul...@suse.com> wrote:
>> >> >>> On 28.01.16 at 21:58, <tleng...@novetta.com> wrote:
>> >> > --- a/xen/include/public/memory.h
>> >> > +++ b/xen/include/public/memory.h
>> >> > @@ -423,11 +423,14 @@ struct xen_mem_access_op {
>> >> > /* xenmem_access_t */
>> >> > uint8_t access;
>> >> > domid_t domid;
>> >> > + uint16_t altp2m_idx;
>> >> > + uint16_t _pad;
>> >> > /*
>> >> > * Number of pages for set op
>> >> > * Ignored on setting default access and other ops
>> >> > */
>> >> > uint32_t nr;
>> >> > + uint32_t _pad2;
>> >>
>> >> Repeating what I had said on v1: So this is a tools only interface,
>> >> yes. But it's not versioned (other than e.g. domctl and sysctl), so
>> >> altering the interface structure is at least fragile.
>> >
>> > Not sure what I can do to address this.
>>
>> Deprecate the old interface and introduce a new one. But other
>> maintainers' opinions would be welcome.
>
> That seems like a very heavy handed solution to me.
I understand that - hence the request for others' opinions.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
