Hi, At 07:22 +0000 on 27 Jan (1453879344), Han, Huaitong wrote: > On Tue, 2016-01-26 at 14:30 +0000, Tim Deegan wrote: > > This seems OK. But can you please: > > - Add this new adjustment once, in paging_gva_to_gfn(), instead of > > adding it to each implementation; and > > - Adjust the comment above the declaration of paging_gva_to_gfn() in > > paging.h to describe this new behaviour. > Although adding adjustment in paging_gva_to_gfn can reduce code > duplication, adding it to each implementation is more readable, becasue > other sections of pfec are handled in each implementation.
True, but since paging_gva_to_gfn() is already non-trivial and this is a different kind of adjustment, I'd still like it done there. I'll leave this to George's discretion as x86/mm maintainer. But in any case, please add the comment describing the new semantics. Cheers, Tim. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
