El 20/01/16 a les 13.46, Ian Campbell ha escrit: > On Wed, 2016-01-20 at 12:57 +0100, Roger Pau Monne wrote: >> libxl__arch_domain_prepare_config has access to the >> libxl_domain_build_info >> struct, so make sure it's properly initialised. >> >> Signed-off-by: Roger Pau Monné <roger....@citrix.com> >> --- >> Cc: Ian Jackson <ian.jack...@eu.citrix.com> >> Cc: Ian Campbell <ian.campb...@citrix.com> >> Cc: Wei Liu <wei.l...@citrix.com> >> --- >> NB: libxl__arch_domain_prepare_config is called from libxl__domain_make. > > I think this is worth moving into the actual commit message. Plus it would > be useful to clarify that while prepare_config has access to b_info it > doesn't touch it right now (but presumably you are about to make it do so).
Right, see 5/5. > If it does touch it then that is currently a bug which should be mentioned > in the commit message and tagged for backport etc. No, it doesn't touch it ATM, so not a bug. > I suspect the reason for the ordering today is that domain_make is intended > to consume create_info, not build_info. However that distinction seems to > me to be an artefact of a much older API structure which doesn't seem to > make much sense now (but we are stuck with it :-() That's right, this create_info vs build_info split seems quite arbitrary, but I don't see myself shaving that yak right now (also changing this is going to be a pain regarding API compatibility). Roger. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
