Ian Campbell writes ("Re: [PATCH] tools/toollog: Drop XTL_NEW_LOGGER()"):
> The underlying issue with all of these is the _undocumented_ nature of the
> assumptions, which is certainly a bug, however those assumptions are not in
> themselves "unreasonable" as was claimed.Maybe I should submit a counter-patch providing documentation. > > If vtable isn't the first element in the structure, it follows a wild > > pointer on error. This could be fixed. > Thank you. Both of these and the lack of documentation should have been > spelled out in the original commit message as reasons for the removal. > BTW your patch removes the logging on failure to allocate, which should > either be fixed or called out in the commit message. I don't think this is a good idea. Ian. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
