On Tue, 2016-01-19 at 14:21 +0000, Ian Campbell wrote: > On Tue, 2016-01-19 at 14:06 +0000, Ian Jackson wrote: > > I am not a fan of the cast as a solution. I would rather, prefer > > to > > regularise the situation. If my co-maintainers agree about the > > desirability of expecting libxl callers to use enum values from Xen > > public headers, > > libxl_shutdown_reason has the same issues, libxl_tsc_mode also might, > as > might libxl_timer_mode. I'm not sure if there are others. > (FTR) libxl_scheduler too, probably?
> I think we > generally handle all these the way psr is handled today (with casts > and/or > explicit conversion switches). > and in fact, libxl_scheduler --touched in another patch of this series-- is also handled in a similar way, and in that case, you seemed to be fine with it? (and I'm not complaining, I'm just genuinely confused :-) ) Dario -- <<This happens because I choose it to happen!>> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
signature.asc
Description: This is a digitally signed message part
_______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
