>>> On 16.12.15 at 15:21, <malcolm.cross...@citrix.com> wrote: > The printks in the switch statement do not match the dprintk used > immediately before the switch statement.
And validly so, due to the lack of a newline on the first one. > This leads to confusing messages > being printed to the Xen console log on non-debug versions of Xen. I'm not sure I follow, but I'm pretty sure what would result on debug builds with your change in place would be even more confusing. If confusing messages result on non-debug builds, then this needs fixing elsewhere (or perhaps is a regression from 1e8193b578, albeit I can't see how that would be). Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel