>>> On 27.11.15 at 10:51, <huaitong....@intel.com> wrote: > @@ -1307,6 +1311,9 @@ void __init noreturn __start_xen(unsigned long mbi_p) > if ( cpu_has_smap ) > set_in_cr4(X86_CR4_SMAP); > > + if ( !opt_pku ) > + setup_clear_cpu_cap(X86_FEATURE_PKU); > + > if ( cpu_has_fsgsbase ) > set_in_cr4(X86_CR4_FSGSBASE);
I don't think this is a good place to do this. It really belongs in cpu/common.c, e.g. next to the xsave disabling. In no case does it belong in the middle of a series of CR4 updates. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel