>>> On 30.11.15 at 21:28, <boris.ostrov...@oracle.com> wrote: > On 11/27/2015 08:42 AM, Roger Pau Monne wrote: >> Instead of choosing the interface to expose to guests based on the guest >> type, do it based on whether the guest has an emulated local apic or not. >> >> Signed-off-by: Roger Pau Monné <roger....@citrix.com> >> Signed-off-by: Boris Ostrovsky <boris.ostrov...@oracle.com> >> Acked-by: Jan Beulich <jbeul...@suse.com> >> Cc: Jan Beulich <jbeul...@suse.com> >> Cc: Andrew Cooper <andrew.coop...@citrix.com> >> --- >> Changes since v8: >> - Don't add the xenpmu hypercalls to the HVM hypercall table (yet). > > Without having the hypercalls available to HVMlite (?) guests these > changes, except possibly those in vmx.c/svm.c, are somewhat pointless > since we never reach patched code. > > I understand desire not to increase size of hypercall tables which we > want to eventually get rid of but is it really worth doing (or rather > not doing) at the cost of not including useful functionality?
Considering that Konrad had designated you as (kind of informal) PVH maintainer, perhaps this is a good reason for you to actually do the folding now (and maybe we should record maintainership in ./MAINTAINERS even if there are no specific files to be listed)? In any event, my ack was made dependent on the HVM hypercall tables being left alone until folded, and I don't think I want to give up on that. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
